mtd-utils.git/ubifs-utils, branch v2.3.1

fsck.ubifs: fix platform dependant ino_t and loff_t formatting

2026-04-13T05:32:41+00:00

On architectures such as armv7-a, ino_t and loff_t are unsigned long long rather than unsigned long. In such cases, the printf format specifier "%lu" is not appropriate and causes an incorrect address offset. mtd-utils/ubifs-utils/fsck.ubifs/problem.c:224 log_out(c, "problem: %s, ino %lu, unreachable dentry %s, type %s%s", problem->desc, ifp->file->inum, c->encrypted && !ifp->file->ino.is_xattr ? "" : dent_node->name, ubifs_get_type_name(dent_node->type), key_type(c, &dent_node->key) == UBIFS_XENT_KEY ? "(xattr)" : ""); fsck.ubifs[484] (/dev/ubi0_0,danger mode): problem: Dentry is unreachable, ino 917, unreachable dentry (null), type checksum_typefile Furthermore, running fsck.ubifs with the --debug=4 option will almost certainly cause a SEGV at the following point. mtd-utils/ubifs-utils/fsck.ubifs/check_files.c:103 dbg_fsck("construct file(%lu) for %s node, TNC location %d:%d, in %s", inum, ubifs_get_key_name(key_type(c, key)), sn->lnum, sn->offs, c->dev_name); To ensure functionality regardless of environment, cast ino_t to unsigned long, since it will never be more than 4 bytes. For loff_t, use %lld and cast accordingly. Signed-off-by: Yuta Hayama Signed-off-by: Tomas Alvarez Vanoli Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: don't use pointers that reference out-of-scope variables

2026-04-13T05:32:41+00:00

sn is a reference to either an ino_node, dent_node, or data_node. When sn is actually used in calls to dbg_fsck() or insert_or_update_file(), these variables must not be out of scope. Signed-off-by: Yuta Hayama Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: extract_files: Include

2025-06-02T05:33:29+00:00

Include to fix the following build error when building with musl: | ../git/ubifs-utils/fsck.ubifs/extract_files.c: In function 'parse_ino_node': | ../git/ubifs-utils/fsck.ubifs/extract_files.c:144:47: error: 'XATTR_LIST_MAX' undeclared (first use in this function) | 144 | if (ino_node->xnms + ino_node->xcnt > XATTR_LIST_MAX) { | | ^~~~~~~~~~~~~~ | ../git/ubifs-utils/fsck.ubifs/extract_files.c:144:47: note: each undeclared identifier is reported only once for each function it appears in | make: *** [Makefile:4374: ubifs-utils/fsck.ubifs/fsck_ubifs-extract_files.o] Error 1 Signed-off-by: Fabio Estevam Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: journal: Include

2025-06-02T05:33:24+00:00

Include the header file to fix the following error when building with musl: | ../git/ubifs-utils/libubifs/journal.c: In function 'ubifs_get_dent_type': | ../git/ubifs-utils/libubifs/journal.c:414:24: error: 'S_IFMT' undeclared (first use in this function) | 414 | switch (mode & S_IFMT) { | | ^~~~~~ | ../git/ubifs-utils/libubifs/journal.c:414:24: note: each undeclared identifier is reported only once for each function it appears in | ../git/ubifs-utils/libubifs/journal.c:415:14: error: 'S_IFREG' undeclared (first use in this function) | 415 | case S_IFREG: Signed-off-by: Fabio Estevam Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: ubifs.h: Include

2025-06-02T05:33:11+00:00

Improve check for GCC compiler version

2025-06-02T05:27:40+00:00

When using unreleased compiler has version like 15.0.1 and that test fails because __GNUC_MINOR__ < 1 becomes true, therefore check for full version string which is more rubust. Signed-off-by: Khem Raj Signed-off-by: David Oberhollenzer

ubifs-utils: common: fix memory leak in devtable.c

2025-06-02T05:23:41+00:00

Report of the static analyzer: Dynamic memory, referenced by 'line', is allocated at devtable.c:356 by calling function 'getline' and lost at devtable.c:388. (line: while (getline(&line, &len, f) != -1) {) Correct explained: Now line is freed in any exit scenario via out_close which eliminates this error. Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Signed-off-by: David Oberhollenzer

ubifs-utils: link libmissing.a in case execinfo.h isn't present

2025-06-02T05:22:10+00:00

On musl execinfo.h doesn't exist, but ubifs-utils uses backtrace() when reporting errors. This results in build failures under musl. Handily, libmissing.a already exists with a stub implementation of backtrace(). Guard the execinfo.h include and if it isn't available instead include libmissing.h, and link to libmissing.a to provide backtrace() if needed. Signed-off-by: Ross Burton Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: libubifs: Update source files from linux kernel 6.13-rc7

2025-01-30T17:30:17+00:00

Update source files from linux kernel 6.13-rc7 aa22f4da2a46. Following changes since 6.8-rc2 41bccc98fb7931d63: 1) 60f16e912a53a ("ubifs: fix sort function prototype") 2) ec724e534dfdd ("ubifs: fix function pointer cast warnings") 3) 39986148bc2ab ("ubifs: fix kernel-doc warnings") 4) 94f5b1571ec8d ("ubifs: Convert to use ERR_CAST()") 5) 4617fb8fc15ef ("ubifs: authentication: Fix use-after-free in ubifs_tnc_end_commit") Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: common: Add descritpions for linux kernel resource files

2025-01-30T17:30:16+00:00

Add descritpions for kernel resource files. Remove crc32 related descritpions, there is no crc32 related files imported from the linux kernel. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer