A mirror of http://git.infradead.org/mtd-utils.git https://git.infraroot.at/mtd-utils.git/atom?h=v2.1.0 2019-02-11T03:58:33+00:00 2019-02-11T03:58:33+00:00 Yufen Yu yuyufen@huawei.com 2019-01-24T09:06:29+00:00 urn:sha1:f18e9636a26f39f6595ed365d31c01e876235b63 In inode_add_xattr(), it malloc a buffer for name, and then passes the bufffer ptr to add_xattr(). The ptr will be used to create a new idx_entry in add_to_index(). However, inode_add_xattr() will free the buffer before return. which can cause double free in write_index(): free(idx_ptr[i]->name) *** Error in `./mkfs.ubifs': double free or corruption (fasttop): 0x0000000000aae220 *** ======= Backtrace: ========= /lib64/libc.so.6(+0x7cbac)[0x7f4881ff5bac] /lib64/libc.so.6(+0x87a59)[0x7f4882000a59] /lib64/libc.so.6(cfree+0x16e)[0x7f48820063be] ./mkfs.ubifs[0x402fbf] /lib64/libc.so.6(__libc_start_main+0xea)[0x7f4881f9988a] ./mkfs.ubifs[0x40356a] Signed-off-by: Yufen Yu <yuyufen@huawei.com> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-12-17T07:13:35+00:00 David Gstir david@sigma-star.at 2018-12-03T13:40:46+00:00 urn:sha1:b1ecfaba533af1895edbdd0ab9bdbbacb1a5ec10 AES-256-XTS is the default since dd0d9c623e22 ("mkfs.ubifs: Use AES-256-XTS as default"), we want that to be correctly reflected in the help output as well. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-09T13:25:26+00:00 Richard Weinberger richard@nod.at 2018-11-07T20:56:35+00:00 urn:sha1:ddeb70df91c0bf2574416279b4b6b9b36262b4c5 Encryption and compression are not friends. Enable compression in encryption mode only if the user explicitly sets a compressor. Signed-off-by: Richard Weinberger <richard@nod.at> Tested-by: Heiko Schocher <hsdenx.de> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-09T13:24:59+00:00 Richard Weinberger richard@nod.at 2018-11-07T20:21:08+00:00 urn:sha1:a20cdd234def1d7b400d76e81cad45b82e0c6215 compr_size has to be in LE16. Signed-off-by: Richard Weinberger <richard@nod.at> Tested-by: Heiko Schocher <hsdenx.de> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-09T13:24:39+00:00 Richard Weinberger richard@nod.at 2018-11-07T20:21:07+00:00 urn:sha1:9ddc6f08c9ecd0a6328ffbef3c444e0a00b2768a We need to check for AES being in 128-cbc mode and not 256-cbc. fscrypt supports only 128-cbc and 256-xts so far. Signed-off-by: Richard Weinberger <richard@nod.at> Tested-by: Heiko Schocher <hsdenx.de> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-01T11:42:41+00:00 Richard Weinberger richard@nod.at 2018-10-18T14:37:18+00:00 urn:sha1:dd0d9c623e22255b16757c524cecf6c7edf8a3de AES-128-CBC should only being used when 256-XTS is too slow on low end hardware. Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-01T11:42:36+00:00 Richard Weinberger richard@nod.at 2018-10-18T14:37:17+00:00 urn:sha1:189d8c872bb1ac5a0280fbf232493ad4e15b09f9 Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-01T11:42:31+00:00 Richard Weinberger richard@nod.at 2018-10-18T14:37:16+00:00 urn:sha1:cc4c5e295f5467edf91bb355e3cd525b3279be31 Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-01T11:42:25+00:00 Richard Weinberger richard@nod.at 2018-10-18T14:37:15+00:00 urn:sha1:13eef731cf3911e5a60891a236d69ce4802e5326 Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> 2018-11-01T11:42:19+00:00 Richard Weinberger richard@nod.at 2018-10-18T14:37:14+00:00 urn:sha1:cef0495f7a536256252a559c88266c8d272bfdb1 fscryptctl reads up to FS_MAX_KEY_SIZE bytes from the source key to compute the descriptor. Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>