mtd-utils.git/ubifs-utils/fsck.ubifs, branch v2.3.1

fsck.ubifs: fix platform dependant ino_t and loff_t formatting

2026-04-13T05:32:41+00:00

On architectures such as armv7-a, ino_t and loff_t are unsigned long long rather than unsigned long. In such cases, the printf format specifier "%lu" is not appropriate and causes an incorrect address offset. mtd-utils/ubifs-utils/fsck.ubifs/problem.c:224 log_out(c, "problem: %s, ino %lu, unreachable dentry %s, type %s%s", problem->desc, ifp->file->inum, c->encrypted && !ifp->file->ino.is_xattr ? "" : dent_node->name, ubifs_get_type_name(dent_node->type), key_type(c, &dent_node->key) == UBIFS_XENT_KEY ? "(xattr)" : ""); fsck.ubifs[484] (/dev/ubi0_0,danger mode): problem: Dentry is unreachable, ino 917, unreachable dentry (null), type checksum_typefile Furthermore, running fsck.ubifs with the --debug=4 option will almost certainly cause a SEGV at the following point. mtd-utils/ubifs-utils/fsck.ubifs/check_files.c:103 dbg_fsck("construct file(%lu) for %s node, TNC location %d:%d, in %s", inum, ubifs_get_key_name(key_type(c, key)), sn->lnum, sn->offs, c->dev_name); To ensure functionality regardless of environment, cast ino_t to unsigned long, since it will never be more than 4 bytes. For loff_t, use %lld and cast accordingly. Signed-off-by: Yuta Hayama Signed-off-by: Tomas Alvarez Vanoli Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: don't use pointers that reference out-of-scope variables

2026-04-13T05:32:41+00:00

sn is a reference to either an ino_node, dent_node, or data_node. When sn is actually used in calls to dbg_fsck() or insert_or_update_file(), these variables must not be out of scope. Signed-off-by: Yuta Hayama Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: extract_files: Include

2025-06-02T05:33:29+00:00

Include to fix the following build error when building with musl: | ../git/ubifs-utils/fsck.ubifs/extract_files.c: In function 'parse_ino_node': | ../git/ubifs-utils/fsck.ubifs/extract_files.c:144:47: error: 'XATTR_LIST_MAX' undeclared (first use in this function) | 144 | if (ino_node->xnms + ino_node->xcnt > XATTR_LIST_MAX) { | | ^~~~~~~~~~~~~~ | ../git/ubifs-utils/fsck.ubifs/extract_files.c:144:47: note: each undeclared identifier is reported only once for each function it appears in | make: *** [Makefile:4374: ubifs-utils/fsck.ubifs/fsck_ubifs-extract_files.o] Error 1 Signed-off-by: Fabio Estevam Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: Add README to describe fsck

2024-11-11T09:32:46+00:00

Add documents to describe fsck, which includes introductions, designment, advantage and limitations. Signed-off-by: Zhihao Cheng Signed-off-by: Zhang Yi Signed-off-by: David Oberhollenzer

fsck.ubifs: Do final committing

2024-11-11T09:32:46+00:00

This is the 18/18 step of fsck. Do final committing, commit problem fixing modifications(which are generated since step 14) to disk, and clear %UBIFS_MST_DIRTY flag for master node. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: Handle disconnected files

2024-11-11T09:32:46+00:00

This is the 17/18 step of fsck. Recover disconnected files into lost+found. If there is no free space left to recover the disconnected files, fsck may delete the files to make filesystem be consistent. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: Check and create the lost+found

2024-11-11T09:32:46+00:00

This is the 16/18 step of fsck. Check whether the lost+found is existed, create a new one if it is not found. This step makes sure that disconnected file can be recovered under the lost+found. Signed-off-by: Huang Xiaojia Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: Check and create the root dir

2024-11-11T09:32:46+00:00

This is the 15/18 step of fsck. Check whether the root dir is existed, create a new one if it is not found. This step makes sure that filesystem can be mounted successful. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubifs-utils: libubifs: Support some file operations

2024-11-11T09:32:46+00:00

Add some file operations, such as ubifs_lookup, ubifs_mkdir, etc., this is a preparation for recovering disconnected files or root dir in fsck. File writing operations are based on the journal subsystem, generated dirty data depends on a new commit in subsequent steps to update disk content. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

fsck.ubifs: Check and correct the index size

2024-11-11T09:32:46+00:00

This is the 14/18 step of fsck. Check and correct the index size by traversing TNC just like dbg_check_idx_size does. This step should be executed after first committing, because 'c->calc_idx_sz' can be changed in 'ubifs_tnc_start_commit' and the initial value of 'c->calc_idx_sz' read from disk is untrusted. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer