mtd-utils.git/ubifs-utils/common/devtable.c, branch v2.3.1A mirror of http://git.infradead.org/mtd-utils.githttps://git.infraroot.at/mtd-utils.git/atom?h=v2.3.12025-06-02T05:23:41+00:00ubifs-utils: common: fix memory leak in devtable.c2025-06-02T05:23:41+00:00AntonMoryakovant.v.moryakov@gmail.com2025-04-24T18:19:22+00:00urn:sha1:2669111e3c60b8e146c174db5d2e7e9991f3dd87
Report of the static analyzer:
Dynamic memory, referenced by 'line', is allocated at devtable.c:356
by calling function 'getline' and lost at devtable.c:388.
(line: while (getline(&line, &len, f) != -1) {)
Correct explained:
Now line is freed in any exit scenario via out_close which eliminates this error.
Triggers found by static analyzer Svace.
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.co
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
ubifs-utils: Add implementations for linux kernel printing functions2024-11-11T09:32:45+00:00Zhihao Chengchengzhihao1@huawei.com2024-11-11T08:36:51+00:00urn:sha1:24f4d8abd9fc7f8e90c0f1d2a652cb8ea790d54c
Add implementations for linux kernel printing functions, because these
functions(eg. pr_debug, pr_err, etc.) are widely used in UBIFS linux
kernel libs. No need to define multiple levels in dbg_msg for debuging,
just replace dbg_msg with pr_debug. Now, there are five levels of
printing messages:
0 - none
1 - error message
2 - warning message [default]
3 - notice message
4 - debug message
This is a preparation for replacing implementation of UBIFS utils with
linux kernel libs.
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
ubifs-utils: Clean up error message printing functions2024-11-11T09:32:45+00:00Zhihao Chengchengzhihao1@huawei.com2024-11-11T08:36:35+00:00urn:sha1:14aa5e63ab989e4f85495e96a74f34d18813caf6
Functions 'err_msg' and 'sys_err_msg' are almost same with 'errmsg' and
'sys_errmsg', since 'errmsg' and 'sys_errmsg' can print programe name,
so replace error message printing functions (ubifs-utils) with common
lib functions(include/common.h).
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
ubifs-utils: Decouple mkfs.ubifs.h out of other modules2024-11-11T09:32:45+00:00Zhihao Chengchengzhihao1@huawei.com2024-11-11T08:36:33+00:00urn:sha1:03ec75b9e6ad4cb372f86d1581c2b1b2ef987c72
Header file mkfs.ubifs.h is included in other modules(eg. compr.c, lpt.c,
fscrypt.h, sign.c), decouple it out of other modules.
There are two parts in mkfs.ubifs.h:
1. common functions, for example dbg_msg, err_msg and write_leb, move
these functions into common/defs.h and common/ubifs.h.
2. devtable related definations, move them into a new header file
common/devtable.h.
Splitting common functions from mkfs.ubifs.h is also a preparation for
importing libubifs(from linux kernel) to replace current UBIFS libs.
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
ubifs-utils: Split common source files from mkfs.ubifs2024-11-11T09:32:45+00:00Zhihao Chengchengzhihao1@huawei.com2024-11-11T08:36:32+00:00urn:sha1:e7e19cd9d8cc0f54ca463c4aebf7c4ef5e4f84f8
Split common source files into common dir from mkfs.ubifs, this is a
preparation for importing libubifs(from linux kernel) to replace
current UBIFS libs.
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>