mtd-utils.git/ubi-utils, branch v2.3.1

ubiattach: fix wording in usage example

2026-04-13T05:32:41+00:00

The usage example 4 describing reserved eraseblocks had awkward and slightly incorrect phrasing ("is total flash chip eraseblocks count"). Reword it for clarity and readability without changing the meaning. Signed-off-by: Mohammad Rahimi Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubi-utils: ubirsvol: resize volume using all available free space

2025-06-02T05:25:34+00:00

useful in resizing last ubi volume, some kind of auto-resize ubinize option. Signed-off-by: Konstantin Menyaev Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubi-utils: mtdinfo: Fix type truncation compiling warning for 'start' variable

2025-01-30T17:30:16+00:00

Fix following compiling warning by using the right format: ubi-utils/mtdinfo.c:207:21: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘long long unsigned int’ Fixes: 78f4f38bd3de8 ("ubi-utils: Fix integer overflow in mtdinfo.c") Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubi-utils: FIX DIVISION BY ZERO in ubinize.c

2024-12-28T10:37:45+00:00

Report of the static analyzer: Variable vi->alignment, whose possible value set allows a zero value at ubinize.c:375, is used as a denominator at ubinize.c:410. If you look at the code more closely, it will be clear that the vi->alignment parameter is obtained from an external file passed as a command line argument. A check was also performed if you pass a test.ini file of the following type to the input: [jffs2-volume] mode=ubi image=../jffs2.img vol_id=1 vol_size=30MiB vol_type=dynamic vol_name=jffs2_volume vol_flags=autoresize vol_alignment=0 and execute the command: ./ubinize -o ubi.img -p 16KiB -m 512 -s 256 test.ini we will get the result: Floating point exception (core dumped) Corrections explained: Updated the validation logic for vi->alignment: - Replaced the check for negative alignment (`vi->id < 0`) with a more comprehensive check for non-positive alignment (`vi->alignment <= 0`). - Updated the corresponding error message to reflect the requirement for a positive volume alignment. This ensures more robust validation and improves error clarity when invalid alignment values are encountered. Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubi-utils: Fix integer overflow in mtdinfo.c

2024-12-17T13:34:24+00:00

Report of the static analyzer: The value of an arithmetic expression 'reginfo->offset + i * reginfo->erasesize' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic Corrections explained: Added casting i and start to unsigned long long Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c

2024-12-17T13:34:18+00:00

Report of the static analyzer: The value of an arithmetic expression 'vol_info.leb_size * args.lebs' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic Corrections explained: The fix ensures values are checked before multiplication. Added casting vol_info.leb_size to long long Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

Unify handling of configure switches

2024-02-19T08:04:00+00:00

Remove the strict check of the with or enable value and use the generated variable instead of our own. Also, don't use WITH_GETRANDOM as an implicit WITH_UBIHEALTHD, split the two autoconf/automake variables and handle them separately. Signed-off-by: David Oberhollenzer

ubiattach: introduce need_resv_pool in UBI_IOCATT

2023-11-20T06:43:34+00:00

The ioctl UBI_IOCATT has been extended with need_resv_pool parameter in [1]. This parameter is used for deciding whether to reserve PEBs for filling pool/wl_pool for target ubi device. This parameter will be effective when fastmap is enabled, which will slow down the frequency of updating fastmap by filling more free PEBs in pool/wl_pool. See details in [2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ac085cfe57df2cc1d7a5c4c5e64b8780c8ad452f [2] https://bugzilla.kernel.org/show_bug.cgi?id=217787 Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

ubiattach: introduce disable_fm in UBI_IOCATT

2023-11-20T06:43:30+00:00

The ioctl UBI_IOCATT has been extended with disable_fm parameter after [1]. This parameter is used for disabling fastmap for target ubi device. If 'disable_fm' is set, ubi doesn't create new fastmap even the module param 'fm_autoconvert' is set, and existed old fastmap will be destroyed after attaching process. A simple test case in [2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=669d204469c46e91d99da24914130f78277a71d3 [2] https://bugzilla.kernel.org/show_bug.cgi?id=216278 Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

Fix printf format specifiers for 64 bit integer types

2023-08-24T08:30:28+00:00

In nandflipbits, nandtest and ubiscan, uint64_t integers are printed to stdout using "%llu" as a format specifier, but on platforms like x86_64, uint64_t is actually typedef'd as `unsigned long` only. For compatibillity across platforms, simply use the C99 printfs macros instead. Signed-off-by: David Oberhollenzer