mtd-utils.git/ubi-utils, branch v2.1.0

mtd-utils: avoid to create two UBI_LAYOUT_VOLUME_ID volume

2019-01-25T11:50:13+00:00

When we create a ubi image by ubinize, a UBI_LAYOUT_VOLUME_ID volume will be created by ubigen_write_layout_vol(). However, after the commit 4c00cf2c5816 (ubiformat: remove no-volume-table option), ubiformat remove novtbl args in format(). As a result, it will also create a layout volume. When we attempt to do ubiattach, it will fail for ubi_compare_lebs error: ubi0 error: ubi_compare_lebs: unsupported on-flash UBI format ubi0 error: ubi_attach_mtd_dev: failed to attach mtd1, error -22 Signed-off-by: Yufen Yu Signed-off-by: David Oberhollenzer

ubi-utils: ubimkvol: Initialize req to zero to make sure no flags are set by default

2018-07-26T22:55:02+00:00

The program expects req.flags to be zero-initialized, but it's not the case. Let's explicitly initialize req to zero at declaration time. Fixes: 7b4a65a27d26 ("ubi-utils: ubimkvol: add support for skipping CRC check of a static volume when opening") Reviewed-by: Quentin Schulz Signed-off-by: Boris Brezillon Signed-off-by: David Oberhollenzer

ubi-utils: ubinize: add support for skipping CRC check of a static volume when opening

2018-06-28T08:23:23+00:00

Let's let the user configure static UBI volume with CRC checking at opening disabled if desired. Introduce the skip-check setting for vol_flags configuration of a volume. There is no point in having both autoresize and skip-check set as skip-check is reserved for static volumes only and it's useless to have a static volume's size set to autoresize. Suggested-by: Boris Brezillon Reviewed-by: Boris Brezillon Signed-off-by: Quentin Schulz Signed-off-by: David Oberhollenzer

ubi-utils: ubimkvol: add support for skipping CRC check of a static volume when opening

2018-06-28T08:23:03+00:00

Let's let the user create static UBI volume with CRC checking at opening disabled if desired. Introduce the `--skipcheck` or `-k` option for such feature. Suggested-by: Boris Brezillon Reviewed-by: Boris Brezillon Signed-off-by: Quentin Schulz Signed-off-by: David Oberhollenzer

ubiformat: remove no-volume-table option

2018-05-12T20:17:16+00:00

Using the -n or --no-volume-table flags, ubiformat can format an mtd device to a broken UBI that does not attach on recent kernel. Only very old UBIs had no volume table. This patch removes the option entirely from ubiformat. Signed-off-by: David Oberhollenzer

ubiformat: process command line arguments first

2018-05-12T19:59:19+00:00

If libmtd_open fails, the program always exists with failure status and prints "MTD subsystem is not present". Even `ubiformat --help` produces the same result, which is definitely undesired. This patch moves command line option processing first to get the desired behavior. Signed-off-by: David Oberhollenzer

ubi-utils: ubiformat.c: convert to integer arithmetic

2018-01-30T08:24:22+00:00

Do not cast percent to double, it is just used as upper limit. Avoid floating point to fix compilation for aarch64 against klibc: error: '-mgeneral-regs-only' is incompatible with floating-point code | int percent = ((double)si->ok_cnt)/si->good_cnt * 100; | ^~~~~~~ Notes: * The checks in the code above this line ensure that si->good_cnt is not 0. * The code assumes si->good_cnt * 100 will not overflow, then we can use (si->ok_cnt * 100) safely because the former is bigger. * The truncated result does not affect the logic: i.e. a value of 49.9 is truncated to 49 and is still <50. Signed-off-by: Andrea Adami Signed-off-by: David Oberhollenzer

ubi-utils: ubicrc32: process command line arguments first

2017-11-03T18:41:32+00:00

When a command line option is used (e.g. --version), the tool tries to open it as a file first, then *uppon success* attempts to process the command line options (including what it assumed to be an input file) which is obviously broken. This patch moves command line processing first and then attempts to open *the first unprocessed* argument. Reported-by: Uwe Kleine-König Signed-off-by: David Oberhollenzer

Mark or fix switch cases that fall through

2017-11-02T00:34:18+00:00

Now that C++17 introduced a special fallthrough keyword for explicitly tagging switch cases that are supposed to fall through, newer gcc versions also implement a feature request from 2002 to warn about maybe unwanted fall-throughs in switch cases in other languages (like C). For C code, we can either add a gcc specific attribute at the end of the switch case, or use a special comment that gcc checks for, indicating that the fall-through behaviour is indeed intended. This patch adds a "/* fall-through */" comment at the end of various case blocks to silence gcc warnings and in some cases a break, where fall-through was probably not intended. Signed-off-by: David Oberhollenzer

mtd-utils: ubinfo: add parameter check

2017-08-10T09:46:49+00:00

Adds a check if the UBI device number is specified when passing a volume name as parameter. This fixes an issue, where by default an inexistent UBI device named "ubi-1" is selected because of missing checks. Signed-off-by: Aaron Marcher Signed-off-by: David Oberhollenzer