A mirror of http://git.infradead.org/mtd-utils.git https://git.infraroot.at/mtd-utils.git/atom?h=v1.5.2 2015-07-06T21:55:03+00:00 2015-07-06T21:55:03+00:00 Dongsheng Yang yangds.fnst@cn.fujitsu.com 2015-07-01T03:44:16+00:00 urn:sha1:5be8bafab070709ccc7535bc895ff16f141e3ad5 Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 2015-07-06T21:52:35+00:00 Dongsheng Yang yangds.fnst@cn.fujitsu.com 2015-07-01T03:44:14+00:00 urn:sha1:ddd8d3b39fc9b84a3bdb94d9ac62d2b20581dca4 Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 2014-11-05T03:00:42+00:00 Brian Norris computersforpeace@gmail.com 2014-09-15T17:35:00+00:00 urn:sha1:6eb466a4f34808d29e3a704f6cabc7f70beebdc8 ioctl(MEMGETREGIONINFO) has one input parameter (regionindex) and three output parameters (info about the erase region). There are two problems in mtdinfo/libmtd here: 1. mtdinfo.c doesn't initialize its region_info_user struct, instead passing uninitialized data to mtd_regioninfo() 2. mtd_regioninfo() fails to utilize the 'regidx' parameter to fill out the regionindex parameter properly, so the garbage from mtdinfo.c is propagated to the ioctl() This means that mtdinfo will continuously probe the same (possibly out-of-range) erase region, instead of looping over the valid regions. Let's fix this in the mtd_regioninfo() helper, and at the same time, let's zero out the mtdinfo.c buffer, as an additional precaution to keep from using uninitialized data. Initial error report from Yang, when running "mtdinfo /dev/mtd0" on a Cavium 6100 board: root@CN61XX:~# mtdinfo /dev/mtd0 mtd0 Name: phys_mapped_flash Type: nor Eraseblock size: 65536 bytes, 64.0 KiB Amount of eraseblocks: 128 (8388608 bytes, 8.0 MiB) Minimum input/output unit size: 1 byte Sub-page size: 1 byte Additional erase regions: 0 Character device major/minor: 90:0 Bad blocks are allowed: false Device is writable: true libmtd: error!: MEMGETREGIONINFO ioctl failed for erase region 0 error 22 (Invalid argument) Eraseblock region 0: info is unavailable libmtd: error!: MEMGETREGIONINFO ioctl failed for erase region 1 error 22 (Invalid argument) Eraseblock region 1: info is unavailable Reported-by: Yang Wei <Wei.Yang@windriver.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 2014-09-16T15:11:50+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2014-09-08T12:05:54+00:00 urn:sha1:15685fe39f1665d53d8b316c8f837f20f8700d4b David Binderman <dcb314@hotmail.com> reports that the following piece of looks wrong: if (!args.subpage_size != mtd->min_io_size) normsg("may be sub-page size is incorrect?"); I totally agree with him and I believe that we actually meant to have no negation in fron to f 'args.subpage_size', so instead, the code should look like this: if (args.subpage_size != mtd->min_io_size) normsg("may be sub-page size is incorrect?"); Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 2014-04-07T10:44:47+00:00 Brian Norris computersforpeace@gmail.com 2014-03-31T17:03:04+00:00 urn:sha1:a9de8952104dcdf48858b9927c33a5f41a28568c UBI's raw flash scan actually scans for UBI data, not UBIFS data (there *are* UBI users that are not UBIFS!), so correct the warning message. This also matches the comment in libscan.h. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 2014-03-31T09:52:38+00:00 Daniel van Gerpen daniel@vangerpen.de 2014-03-29T23:52:10+00:00 urn:sha1:eac3108f123f7fcdfd1f2e368adb5729111574b3 Amended by Artem. Signed-off-by: Daniel van Gerpen <daniel@vangerpen.de> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 2014-03-25T07:54:48+00:00 Ezequiel Garcia ezequiel.garcia@free-electrons.com 2014-03-14T14:25:24+00:00 urn:sha1:6a9db93c239ff61412ba6629919b4411d836ae23 With the addition of block device access to UBI volumes, we now add a simple userspace tool to access the new ioctls. Usage of this tool is as simple as it gets: $ ubiblock --create /dev/ubi0_0 will create a new block device /dev/ubiblock0_0, and $ ubiblock --remove /dev/ubi0_0 will remove the device. Artem: slightly changed the header comment. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 2013-10-22T23:19:23+00:00 Huang Shijie b32955@freescale.com 2013-08-20T05:58:37+00:00 urn:sha1:263e138719f6358c3cf2ce47d6254cebef31dd4b In the current code, the MTD_NANDFLASH stands for both the SLC and MLC. In the kernel, the MTD_NANDFLASH only stands for the SLC now, so in order to keep the logic unchanged, we should also check the MLC NAND by MTD_MLCNANDFLASH. Signed-off-by: Huang Shijie <b32955@freescale.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> 2013-07-01T06:15:24+00:00 Mike Frysinger vapier@gentoo.org 2013-05-09T17:59:24+00:00 urn:sha1:ab8c6fb93ce9db0f09401c4b819b0b277dc00340 This already has a --size option for controlling how many bytes to read from the input. Add a --skip option to control the offset into the input too. This way people don't have to do `dd | ubiupdatevol`. While we're here, I've fixed the types used with args.size and the read loop so that they can hold the right sizes (like setting a 32bit+ size). Signed-off-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 2013-07-01T05:55:55+00:00 Mike Frysinger vapier@gentoo.org 2013-05-08T16:27:25+00:00 urn:sha1:dbe0fd17f2323f108715db0bd0f734e9563e40d8 We've got a few tools that prompt the user for "yes/no" questions. Add a common helper to simplify the various implementations. Signed-off-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>