mtd-utils.git/ubi-utils/ubinize.c, branch v2.3.1

ubi-utils: FIX DIVISION BY ZERO in ubinize.c

2024-12-28T10:37:45+00:00

Report of the static analyzer: Variable vi->alignment, whose possible value set allows a zero value at ubinize.c:375, is used as a denominator at ubinize.c:410. If you look at the code more closely, it will be clear that the vi->alignment parameter is obtained from an external file passed as a command line argument. A check was also performed if you pass a test.ini file of the following type to the input: [jffs2-volume] mode=ubi image=../jffs2.img vol_id=1 vol_size=30MiB vol_type=dynamic vol_name=jffs2_volume vol_flags=autoresize vol_alignment=0 and execute the command: ./ubinize -o ubi.img -p 16KiB -m 512 -s 256 test.ini we will get the result: Floating point exception (core dumped) Corrections explained: Updated the validation logic for vi->alignment: - Replaced the check for negative alignment (`vi->id < 0`) with a more comprehensive check for non-positive alignment (`vi->alignment <= 0`). - Updated the corresponding error message to reflect the requirement for a positive volume alignment. This ensures more robust validation and improves error clarity when invalid alignment values are encountered. Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

Fix typos found by Debian's lintian tool

2020-09-11T13:40:54+00:00

Signed-off-by: Bastian Germann Signed-off-by: David Oberhollenzer

ubinize: Exit with non-zero exit code on error.

2019-07-02T12:33:07+00:00

...specifically -1 in all of the new cases. Signed-off-by: Patrick Doyle Signed-off-by: David Oberhollenzer

ubi-utils: ubinize: add support for skipping CRC check of a static volume when opening

2018-06-28T08:23:23+00:00

Let's let the user configure static UBI volume with CRC checking at opening disabled if desired. Introduce the skip-check setting for vol_flags configuration of a volume. There is no point in having both autoresize and skip-check set as skip-check is reserved for static volumes only and it's useless to have a static volume's size set to autoresize. Suggested-by: Boris Brezillon Reviewed-by: Boris Brezillon Signed-off-by: Quentin Schulz Signed-off-by: David Oberhollenzer

Merge rest of ubiutils-common into libmtd common

2016-11-17T10:36:56+00:00

This patch moves the remaining 3 functions from ubiutils-common.{c,h} into libmtd common.{c,h}. The functions are only generic utility functions that other mtd-utils programs may also find usefull and every program that uses libubi links against libmtd anyway so there is no real reason for keeping around a seperate ubiutils-common with only generic helper functions. Signed-off-by: David Oberhollenzer

Add ubinize manpage

2016-11-17T10:36:56+00:00

This patch removes the lengthy help text from the ubinize utility that attempted to describte the file format and every minor detail, and reformats it into a more readable man page. Signed-off-by: David Oberhollenzer

mtd-utils: ubinize: Always return error code (at least -1) in case of an error

2015-09-29T18:46:41+00:00

ubinize should not fail silenty, this can be very annoying when using it from other tools that rely on the exit code for determining the success of their operation. Signed-off-by: Enrico Jorns Signed-off-by: Brian Norris

ubinize: fix usage text

2013-07-01T05:37:54+00:00

Drop duplicate "and the", and tweak grammar slightly. Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

mkfs.ubifs/ubinize: increase PEB size limit to 2MiB

2011-08-20T04:07:37+00:00

Signed-off-by: Artem Bityutskiy

mtd-utils: switch more utils to unified versioning

2011-06-29T05:42:40+00:00

More utilities now use the common VERSION system. For utils that printed a very simple message, we use the new common_print_version() "function." Signed-off-by: Brian Norris Acked-by: Mike Frysinger Signed-off-by: Artem Bityutskiy