mtd-utils.git/tests/ubi-tests/integ.c, branch v2.3.1

ubi-tests: ubi_mkvol_request: Fully initialize 'struct ubi_mkvol_request req'

2019-06-16T10:27:10+00:00

'struct ubi_mkvol_request req' is one parameter of the function 'ubi_mkvol' , this parameter will be passed to kernel and then be checked. It acts as a local variable in many ubi tests, such as io_basic, io_read, mkvol_bad, mkvol_basic, etc. After commit c355aa465fce ("ubi: expose the volume CRC check skip flag") in linux-stable, 'struct ubi_mkvol_request' supports a new configuration named 'flags', and req.flags will be checked in kernel function 'verify_mkvol_req'. Currently, there is no initialization for req.flags before 'ubi_mkvol' invoked. So, req.flags can be an arbitrary number passed to kernel. When we run ubi tests in qemu (x86_64, kernel image: 5.2.0-rc4), the following errors may occur: ====================================================================== ====================================================================== ====================================================================== Test on mtdram, fastmap enabled, VID header offset factor 1 ====================================================================== ====================================================================== ====================================================================== mtdram: 16MiB, PEB size 16KiB, fastmap enabled Running mkvol_basic /dev/ubi0 Running mkvol_bad /dev/ubi0 [mkvol_bad] test_mkvol():105: ubi_mkvol failed with error 22 (Invalid argument), expected 28 (No space left on device) [mkvol_bad] test_mkvol():105: bytes = 16060929 Error: mkvol_bad failed FAILURE This patch fully initializes every 'struct ubi_mkvol_request req' passed to 'ubi_mkvol', which can fix the bug that the ubi test failed caused by that req.flags was not initialized. And it is still compatible with old kernel before kernel commit c355aa465fce ("ubi: expose the volume CRC check skip flag"). ---------------------------------------- Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

mtd-utils: Instead of doing preprocessor magic, just output off_t as long long

2018-10-02T12:00:28+00:00

Fix warnings abot PRIdoff_t in libmtd.c, in mtd_read (and mtd_write): In file included from ../git/lib/libmtd.c:40:0: ../git/lib/libmtd.c: In function 'mtd_read': ../git/include/common.h:110:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t {aka long long int}' [-Wformat=] ../git/include/common.h:120:2: note: in expansion of macro 'errmsg' errmsg(fmt, ##__VA_ARGS__); \ ^~~~~~ ../git/lib/libmtd.c:1082:10: note: in expansion of macro 'sys_errmsg' return sys_errmsg("cannot seek mtd%d to offset %"PRIdoff_t, ^~~~~~~~~~ /usr/lib/klibc/include/inttypes.h:28:17: note: format string is defined here #define PRId32 "d" Signed-off-by: Thorsten Glaser Signed-off-by: David Oberhollenzer

Remove unused variables and functions

2017-06-28T08:27:35+00:00

Signed-off-by: David Oberhollenzer

common: Fix 'unchecked return code' warnings

2016-12-06T18:38:16+00:00

Several tools are simply not checking return code of functions marked with 'warn_unused_result'. Provide wrappers for the read/write functions to avoid patching old code and providing proper error handling. Fix the remaining ones (calls to fgets() and system()). Signed-off-by: Boris Brezillon

ubi-tests: switch to using common.h from the top level

2012-11-16T08:09:54+00:00

Sorry, the commit is huge, I just did not have time to split it. Signed-off-by: Artem Bityutskiy

ubi-tests: rename common.[ch] to helpers.[ch]

2012-11-16T07:52:21+00:00

... to avoid confusion when the local common.h shadows the top-level common.h. Signed-off-by: Artem Bityutskiy

consistency between u_int32_t / off_t / off64_t

2012-09-25T15:06:50+00:00

We should use the off_t type instead of off64_t or u_int32_t as its length is controlled by the WITHOUT_LARGEFILE flag. Signed-off-by: Richard Genoud Signed-off-by: Artem Bityutskiy

tests: ubi-tests: seed_random_generator() was used w/o prototype

2011-04-05T14:27:43+00:00

Signed-off-by: Andy Shevchenko Signed-off-by: Artem Bityutskiy

ubi-test: seed the random genrator in tests

2010-06-15T11:02:48+00:00

Add a common seed_random_generator() and make tests use it for seeding the random generator. Signed-off-by: Artem Bityutskiy

ubi-tests: remove some junk from the integ test

2010-06-15T11:02:47+00:00

Signed-off-by: Artem Bityutskiy