mtd-utils.git/tests/fs-tests/integrity, branch v2.0.1

Eliminate warnings about missing prototypes

2017-06-28T08:27:31+00:00

This patch eliminates warnings generated by the -Wmissing-prototypes option. With this flag set, we are now forced to have prototypes for all global, exported functions, that have to be made visible to the definitions and we are forced to mark all local functions as static. Signed-off-by: David Oberhollenzer

ubi-utils: Return error code if command line option is unknown

2017-06-14T09:00:30+00:00

The tools in question will quit with an exit code 0 if the command line option was not recognized. By returning an error code a calling script has the possibility to distinguish between a real success and an invalid invocation. We need to return -1 instead of EXIT_FAILURE to be consistent with the other exit code places. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

Add libmissing

2016-11-17T10:36:55+00:00

This patch adds a libmissing library to mtd-utils, containing implementations of functionality found in glibc but typically missing from embedded C libraries such as uclibc ot musl. For now, the library only contains stub implementations of the backtrace*() family of functions. Signed-off-by: David Oberhollenzer Signed-off-by: Richard Weinberger

Unify version string printing

2016-11-17T10:36:55+00:00

When a program does sophisticated enough command line processing (i.e. getopt), make sure it responds to -V and --version. When a program prints a version string, make sure it uses the common_print_version macro to print out its name, that it is part of mtd-utils and the mtd-utils version from the build system in a fashion similar to common program packages like the GNU coreutils. When a program responds to -V/--version or -h/--help, make sure it reports success exit status. Signed-off-by: David Oberhollenzer Signed-off-by: Richard Weinberger

Integrate tests into autotools build system

2016-11-17T10:36:55+00:00

Add automake files for the test binaries. If configured to do so, install the test binaries to libexec/mtd-utils and use autoconf to fix the paths in the test scripts. Signed-off-by: David Oberhollenzer Signed-off-by: Richard Weinberger

fs-tests: integrity: don't include header

2016-08-25T13:33:09+00:00

In commit ca7a5eda221d("integck.c: Fix buffer overflow in save_file") we started including header . But with musl C library, we get following build error integck.c:37:28: fatal error: bits/stdio_lim.h: No such file or directory #include ^ compilation terminated. make[2]: *** [integck] Error 1 Header is not available in musl C library. However has all definition that supposed to be providing. Moreover shouldn't be included directly instead we should be using . Since we already include and in case of uClibc or glibc gets included internally, we can safely remove it. This build issue is found by Buildroot autobuilder http://autobuild.buildroot.net/results/175/1754861457af520480cc34d7d2d0edff2868ff66/ Fixes: ca7a5eda221d("integck.c: Fix buffer overflow in save_file") Signed-off-by: Rahul Bedarkar Signed-off-by: Richard Weinberger

mtd-utils: integck: Use $(CC) and $(AR) instead of 'gcc' and 'ar' consistently

2014-04-15T13:01:12+00:00

Not using the macros may be a problem when cross-compiling. Signed-off-by: Mats Karrman Signed-off-by: Artem Bityutskiy

integck: fix identation a bit

2013-03-11T08:44:29+00:00

Signed-off-by: Artem Bityutskiy

integck.c: Fix buffer overflow in save_file

2013-03-11T08:40:23+00:00

In the problem above I've spend several hours waiting for the issue to appear, only to had the 'luck' that it was found in a file whose name was 256 bytes in length, resulting in the write to fail. Closer examination showed that the buffer to store the path was 256 bytes in length, but this buffer also includes /tmp and the read/write suffix and should be able to contain a filename which is up to 255 bytes (NAME_MAX in linux/limits.h) in size which is a bad fit. So that array is modified to FILENAME_MAX (stdio_lim.h) and some checking is added to truncate the filename should it cause an overflow. The following log shows the first patch in action (see the correct seed), and shows why this third patch is needed: integck: File Data: integck: Offset: 0 Size: 1 Seed: 5008310 R.Off: 0 integck: 1 writes integck: ============================================ integck: Write Info: integck: Offset: 0 Size: 1 Seed: 5008310 R.Off: 0 integck: Offset: 0 Size: 1 Seed: 8246352 R.Off: 0 integck: Offset: 0 Size: 1 Seed: 5078796 R.Off: 0 integck: Offset: 0 Size: 1 Seed: 2267087 R.Off: 0 integck: Offset: 0 Size: 1 Seed: 3602680 R.Off: 0 integck: 5 writes or truncations integck: ============================================ integck: Saving /tmp/yqcnfygfitaatyeyvffrguegcdttamcnyhowhgieljfuxfipiljsjcbluaeaghwyinkggommsbwnmvekihgnwgiibccpbwfrpxuxwkmnyghnutrudienngxwgorudbskedaaekiuiyqksfazrwzfwbfhzjjqoiulebtlpbfiuffmsnguqkjzqjqizimsmhbqqagaebjdhqwmzdxghiavtcxubegawlgtvstuqurkurpnrckjfkgostdtpg.integ.sav.readn integck: error!: condition 'w_fd != -1' failed in save_file() at integck.c:1445 integck: error 36 (File name too long) Signed-off-by: Elie De Brauwer Signed-off-by: Artem Bityutskiy

integck.c: rework file_check_data to immediately dump the buffer containing the errors

2013-03-11T08:36:02+00:00

See my problem description int the previous commit, the point is that integck in file_check_data reads a buffer, and then checks if the data is correct, it will do a seek(0), and reread from the same fd. The point is that in the scenario I observed integck failed (due to a buffer mismatch) but the it saved (and what was in flash) was actually correct. So I modified this function to dump the buffers to stderr at the moment an error is found. Signed-off-by: Elie De Brauwer Signed-off-by: Artem Bityutskiy