mtd-utils.git/nand-utils, branch v2.3.1

nand-utils: nanddump: Fix unexpected type compiling warning for argument 'dumpfile'

2025-01-30T17:30:16+00:00

The const pointer argument cannot be passed into libc function 'free()', otherwise the compiler will complain following message: nand-utils/nanddump.c:168:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type Fixes: c89009463888 ("nanddump: don't leak copied command line arguments") Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

nand-utils: Fix integer overflow in nandflipbits.c

2024-12-17T13:34:23+00:00

Report of the static analyzer: The value of an arithmetic expression 'bit_to_flip->block * mtd.eb_size + blkoffs' is a subject to overflow because its operands are not cast to a larger data type before performing arith$ Corrections explained: Prevent arithmetic overflow in OOB read operation Resolved an issue where the calculation of the offset in the OOB read operation could overflow due to operands not being cast to a larger data type. Specifically, the multiplication of bi$ Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Add support for testing continuous reads

2024-10-08T06:14:36+00:00

In order to trigger a continuous read, the user needs to request more than one data page. So far the tool would split the length into page chunks. This is no longer the case when the -C option is passed (-c is already used for the canonical output style). Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Explicitely use the page size when relevant

2024-10-08T06:14:33+00:00

Using bs when skipping the bad sector is abusive as what we want is using the size of a block and the size of a page. The fact that bs currently is the size of a page is misleading here, has I intend to make this amount grow. Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Use a specific variable for the buffer size

2024-10-08T06:14:30+00:00

The read buffer size happen to be as big as the bs variable, but this is going to change. When accessing the buffer size, use a specific variable instead. Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

Fix printf format specifiers for 64 bit integer types

2023-08-24T08:30:28+00:00

In nandflipbits, nandtest and ubiscan, uint64_t integers are printed to stdout using "%llu" as a format specifier, but on platforms like x86_64, uint64_t is actually typedef'd as `unsigned long` only. For compatibillity across platforms, simply use the C99 printfs macros instead. Signed-off-by: David Oberhollenzer

mtd-utils: nandtest: handle large nand devices

2023-08-23T11:09:28+00:00

Running nandtest on devices with sizes of 4Gb or more does not work, as the size returned in mtd_info_user is reported as 0 for 4Gb devices for example. The patch uses sysfs to figure out the size of the nand device (as recommended in a comment in include/mtd/mtd-abi.h) and changes sizes and offsets to 64 bit values. [From: Christian Wendt ] Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

nandflipbits: fix corrupted oob

2022-06-27T05:58:48+00:00

If a bit is flipped in block 1 or higher, the OOB is corrupted with the OOB of block 0. Mtd_read_oob API has to take into account the block number to be able to calculate the right offset. Fixes: 9fc8db29cf62 ("mtd-utils: Add nandflipbits tool") Signed-off-by: Christophe Kerello Signed-off-by: David Oberhollenzer

mtd-utils: nanddump: fix writing big images on 32bit machines

2022-06-08T07:53:51+00:00

When writing a full 4GiB NAND to a file end_addr becomes 0x100000000. With that writing out the first page to the file doesn't happen because size_left is calculated to 0x100000000 - 0 = 0x100000000 which is then truncated to 32bit and becomes zero. Fix this by using an appropriate 64bit type for size_left. Signed-off-by: Sascha Hauer Signed-off-by: David Oberhollenzer

nandwrite: warn about writing 0xff blocks

2022-03-28T06:49:40+00:00

Such blocks may be incorrectly treated as empty (even though they may have non-erase OOB). Warn about it so people may start useing --skip-all-ffs . Signed-off-by: Rafał Miłecki Signed-off-by: David Oberhollenzer