mtd-utils.git/nand-utils, branch v2.1.2

mtd-utils: Fix wrong argument to sizeof in nanddump

2020-02-09T21:13:18+00:00

Some temporary buffers are allocated with "sizeof(pointer) * count" as size argument, which cannot possibly be correct. Assuming what was meant was "sizeof(pointer[0]) * count" makes sense in the context of how the buffers are used, but is actually pretty pointless, since the buffers are unsigend char. Signed-off-by: David Oberhollenzer

mtd-utils: Fix potential negative arguments passed to close(2)

2020-02-09T21:13:18+00:00

Many tools open a file descriptor, close it a the end and have some form of error path in between that jumps to the end. In some cases, if opening the file fails the error path is taken and the utility ends up closing one or more invalid file descriptors. It's technically not a real issue but something that pretty much any static analysis tool barks at. Signed-off-by: David Oberhollenzer

nanddump: don't leak copied command line arguments

2019-11-10T14:30:04+00:00

For some command line flags, the argument string is copied. Simply writing over the buffer leads to a resource leak if the same flag is specified on the command line more than once. This patch adds a free() call to the old buffer before overwriting it with the new copy. Signed-off-by: David Oberhollenzer

Mark or fix switch cases that fall through

2017-11-02T00:34:18+00:00

Now that C++17 introduced a special fallthrough keyword for explicitly tagging switch cases that are supposed to fall through, newer gcc versions also implement a feature request from 2002 to warn about maybe unwanted fall-throughs in switch cases in other languages (like C). For C code, we can either add a gcc specific attribute at the end of the switch case, or use a special comment that gcc checks for, indicating that the fall-through behaviour is indeed intended. This patch adds a "/* fall-through */" comment at the end of various case blocks to silence gcc warnings and in some cases a break, where fall-through was probably not intended. Signed-off-by: David Oberhollenzer

Add no-return attribute to usage() style functions

2017-11-02T00:33:32+00:00

A common pattern in command line processing is having a usage() function that prints out how to use the command line options and then terminates. The function is typically used inside a switch block for command line options like `-h' or unknown options. In a lot of places, the break keyword is omitted, because the function exits anyway. However, this triggers gcc warnings about implicit fall-through. Rather than adding a phony "/* fall-through */" this patch flags the usage() style function with a gcc attribute, indicating that they do not return and removes further superfluous break statements. Signed-off-by: David Oberhollenzer

Remove unused variables and functions

2017-06-28T08:27:35+00:00

Signed-off-by: David Oberhollenzer

Eliminate warnings about missing prototypes

2017-06-28T08:27:31+00:00

This patch eliminates warnings generated by the -Wmissing-prototypes option. With this flag set, we are now forced to have prototypes for all global, exported functions, that have to be made visible to the definitions and we are forced to mark all local functions as static. Signed-off-by: David Oberhollenzer

Use defines for exit code values

2017-06-14T08:53:15+00:00

Make the usage of exit consist. That is use the pre defined exit values. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

nanddump: Add --skip-bad-blocks-to-start option

2017-01-18T13:42:25+00:00

The --skip-bad-blocks-to-start option will increase the start address by the size of each bad block encountered between the start of the partition and the specified start address. This can be useful if other readers of the partition will be reading using a simple bad-block-skipping algorithm. Signed-off-by: Mike Crowe Signed-off-by: David Oberhollenzer

nandwrite: Add --skip-bad-blocks-to-start option

2017-01-18T13:42:10+00:00

The --skip-bad-blocks-to-start option will increase the seek offset by the size of each bad block encountered between the start of the partition and the specified start address. This can be useful when writing part way through a partition that will be read using a simple bad-block-skipping algorithm. Signed-off-by: Mike Crowe Signed-off-by: David Oberhollenzer