mtd-utils.git/nand-utils/nftl_format.c, branch v2.3.1A mirror of http://git.infradead.org/mtd-utils.githttps://git.infraroot.at/mtd-utils.git/atom?h=v2.3.12017-11-02T00:33:32+00:00Add no-return attribute to usage() style functions2017-11-02T00:33:32+00:00David Oberhollenzerdavid.oberhollenzer@sigma-star.at2017-09-21T11:36:42+00:00urn:sha1:cb2fcfc0a1da3cfac9094abf1d11c23653937395
A common pattern in command line processing is having a usage()
function that prints out how to use the command line options and
then terminates.
The function is typically used inside a switch block for command
line options like `-h' or unknown options. In a lot of places, the
break keyword is omitted, because the function exits anyway. However,
this triggers gcc warnings about implicit fall-through.
Rather than adding a phony "/* fall-through */" this patch flags the
usage() style function with a gcc attribute, indicating that they do
not return and removes further superfluous break statements.
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Eliminate warnings about missing prototypes2017-06-28T08:27:31+00:00David Oberhollenzerdavid.oberhollenzer@sigma-star.at2017-06-22T11:37:40+00:00urn:sha1:ca517e8b320c7a31c3a147fb1212ddb33cabd919
This patch eliminates warnings generated by the -Wmissing-prototypes
option. With this flag set, we are now forced to have prototypes for
all global, exported functions, that have to be made visible to the
definitions and we are forced to mark all local functions as static.
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Use defines for exit code values2017-06-14T08:53:15+00:00Daniel Wagnerdaniel.wagner@siemens.com2017-06-12T10:50:43+00:00urn:sha1:ccffc105b0b361150666f97b59ac72cff8466e9b
Make the usage of exit consist. That is use the pre defined exit
values.
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
common: Fix 'unchecked return code' warnings2016-12-06T18:38:16+00:00Boris Brezillonboris.brezillon@free-electrons.com2016-11-25T17:30:41+00:00urn:sha1:bfb33f2f46a40023aa9820f4cdd99281e41250c1
Several tools are simply not checking return code of functions marked
with 'warn_unused_result'.
Provide wrappers for the read/write functions to avoid patching old
code and providing proper error handling.
Fix the remaining ones (calls to fgets() and system()).
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Unify version string printing2016-11-17T10:36:55+00:00David Oberhollenzerdavid.oberhollenzer@sigma-star.at2016-07-19T13:06:58+00:00urn:sha1:7dd42c510dc8ab10f52dcc2d20dc8af412be0744
When a program does sophisticated enough command line processing
(i.e. getopt), make sure it responds to -V and --version.
When a program prints a version string, make sure it uses the
common_print_version macro to print out its name, that it is part
of mtd-utils and the mtd-utils version from the build system in a
fashion similar to common program packages like the GNU coreutils.
When a program responds to -V/--version or -h/--help, make sure it
reports success exit status.
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Signed-off-by: Richard Weinberger <richard@nod.at>
mtd-utils: Restructure the mtd-utils source.2015-11-11T22:38:40+00:00Dongsheng Yangyangds.fnst@cn.fujitsu.com2015-10-31T03:12:01+00:00urn:sha1:7d81790ced345585b1e647ca9d0f6678e7062fa4
* There is no code modification in this commit, only moving
* the files to proper place.
The user tools looks a little messy as we place almost
the all tools in the root directory of mtd-utils. To make
it more clear, I propose to introduce the following structure
for our source code.
mtd-utils/
|-- lib
|-- include
|-- misc-utils
|-- jffsX-utils
|-- nand-utils
|-- nor-utils
|-- ubi-utils
|-- ubifs-utils
`-- tests
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>