mtd-utils.git/nand-utils/nanddump.c, branch v2.3.1

nand-utils: nanddump: Fix unexpected type compiling warning for argument 'dumpfile'

2025-01-30T17:30:16+00:00

The const pointer argument cannot be passed into libc function 'free()', otherwise the compiler will complain following message: nand-utils/nanddump.c:168:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type Fixes: c89009463888 ("nanddump: don't leak copied command line arguments") Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Add support for testing continuous reads

2024-10-08T06:14:36+00:00

In order to trigger a continuous read, the user needs to request more than one data page. So far the tool would split the length into page chunks. This is no longer the case when the -C option is passed (-c is already used for the canonical output style). Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Explicitely use the page size when relevant

2024-10-08T06:14:33+00:00

Using bs when skipping the bad sector is abusive as what we want is using the size of a block and the size of a page. The fact that bs currently is the size of a page is misleading here, has I intend to make this amount grow. Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

nand-utils: nanddump: Use a specific variable for the buffer size

2024-10-08T06:14:30+00:00

The read buffer size happen to be as big as the bs variable, but this is going to change. When accessing the buffer size, use a specific variable instead. Signed-off-by: Miquel Raynal Signed-off-by: David Oberhollenzer

mtd-utils: nanddump: fix writing big images on 32bit machines

2022-06-08T07:53:51+00:00

When writing a full 4GiB NAND to a file end_addr becomes 0x100000000. With that writing out the first page to the file doesn't happen because size_left is calculated to 0x100000000 - 0 = 0x100000000 which is then truncated to 32bit and becomes zero. Fix this by using an appropriate 64bit type for size_left. Signed-off-by: Sascha Hauer Signed-off-by: David Oberhollenzer

mtd-utils: Fix wrong argument to sizeof in nanddump

2020-02-09T21:13:18+00:00

Some temporary buffers are allocated with "sizeof(pointer) * count" as size argument, which cannot possibly be correct. Assuming what was meant was "sizeof(pointer[0]) * count" makes sense in the context of how the buffers are used, but is actually pretty pointless, since the buffers are unsigend char. Signed-off-by: David Oberhollenzer

mtd-utils: Fix potential negative arguments passed to close(2)

2020-02-09T21:13:18+00:00

Many tools open a file descriptor, close it a the end and have some form of error path in between that jumps to the end. In some cases, if opening the file fails the error path is taken and the utility ends up closing one or more invalid file descriptors. It's technically not a real issue but something that pretty much any static analysis tool barks at. Signed-off-by: David Oberhollenzer

nanddump: don't leak copied command line arguments

2019-11-10T14:30:04+00:00

For some command line flags, the argument string is copied. Simply writing over the buffer leads to a resource leak if the same flag is specified on the command line more than once. This patch adds a free() call to the old buffer before overwriting it with the new copy. Signed-off-by: David Oberhollenzer

Mark or fix switch cases that fall through

2017-11-02T00:34:18+00:00

Now that C++17 introduced a special fallthrough keyword for explicitly tagging switch cases that are supposed to fall through, newer gcc versions also implement a feature request from 2002 to warn about maybe unwanted fall-throughs in switch cases in other languages (like C). For C code, we can either add a gcc specific attribute at the end of the switch case, or use a special comment that gcc checks for, indicating that the fall-through behaviour is indeed intended. This patch adds a "/* fall-through */" comment at the end of various case blocks to silence gcc warnings and in some cases a break, where fall-through was probably not intended. Signed-off-by: David Oberhollenzer

nanddump: Add --skip-bad-blocks-to-start option

2017-01-18T13:42:25+00:00

The --skip-bad-blocks-to-start option will increase the start address by the size of each bad block encountered between the start of the partition and the specified start address. This can be useful if other readers of the partition will be reading using a simple bad-block-skipping algorithm. Signed-off-by: Mike Crowe Signed-off-by: David Oberhollenzer