mtd-utils.git/misc-utils, branch v2.0.2

misc-utils: flash_erase: Fix Jffs2 type flash erase problem

2018-04-10T13:39:01+00:00

Currently, Jffs2 clean marker is not written actually, because the oob write length is set to 0 when do mtd_write(). So, get OOB available size at first, and set the correct clean marker length, then program clean marker to free OOB area. Fixes: d7e86124d55b ("mtd-utils: Support jffs2 flash-erase for large OOB (>32b)") Signed-off-by: Xiaolei Li Signed-off-by: David Oberhollenzer

Enable further warning flags, address new warnings

2017-11-03T18:41:32+00:00

mtd_debug: Remove a duplicate if case. MTD_CAP_NANDFLASH has only one flag set (MTD_WRITEABLE). Directly below, we had a check for MTD_WRITEABLE in the else branch which can't possible ever have triggered. Checking for MTD_WRITEABLE in addition to the CAP constants was probably not intended anyway, given the check for the individual flags if all else fails. integck: We already established that "r" is less than the number of elements in the list, so the loop condition doesn't need to check if w is NULL in addition. At least this way, the compiler "gets" that w cannot be NULL below and doesn't issue warnings. Signed-off-by: David Oberhollenzer

Mark or fix switch cases that fall through

2017-11-02T00:34:18+00:00

Now that C++17 introduced a special fallthrough keyword for explicitly tagging switch cases that are supposed to fall through, newer gcc versions also implement a feature request from 2002 to warn about maybe unwanted fall-throughs in switch cases in other languages (like C). For C code, we can either add a gcc specific attribute at the end of the switch case, or use a special comment that gcc checks for, indicating that the fall-through behaviour is indeed intended. This patch adds a "/* fall-through */" comment at the end of various case blocks to silence gcc warnings and in some cases a break, where fall-through was probably not intended. Signed-off-by: David Oberhollenzer

Add no-return attribute to usage() style functions

2017-11-02T00:33:32+00:00

A common pattern in command line processing is having a usage() function that prints out how to use the command line options and then terminates. The function is typically used inside a switch block for command line options like `-h' or unknown options. In a lot of places, the break keyword is omitted, because the function exits anyway. However, this triggers gcc warnings about implicit fall-through. Rather than adding a phony "/* fall-through */" this patch flags the usage() style function with a gcc attribute, indicating that they do not return and removes further superfluous break statements. Signed-off-by: David Oberhollenzer

misc-utils: initialize "ip" in docfdisk to NULL

2017-10-05T11:40:37+00:00

Technically it is initializied in the for loop right before being used. From the conditional above, we know that the for loop is executed at least once and the variable is always initialized, but gcc doesn't appear to perform the same reasoning. This patch adds an initialization of the variable for the sake of making the compiler happy. Signed-off-by: David Oberhollenzer

Eliminate warnings about missing prototypes

2017-06-28T08:27:31+00:00

This patch eliminates warnings generated by the -Wmissing-prototypes option. With this flag set, we are now forced to have prototypes for all global, exported functions, that have to be made visible to the definitions and we are forced to mark all local functions as static. Signed-off-by: David Oberhollenzer

Move libfec declarations to public header in global include directory

2017-06-28T08:27:24+00:00

Signed-off-by: David Oberhollenzer

ftl_format: Use return directly to leave main function

2017-06-14T08:55:26+00:00

We can use return with the exit code instead of the sliglty odd exit, return pattern. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

flashcp: Drop exit code defines

2017-06-14T08:55:26+00:00

The EXIT_{FAILURE|SUCCESS} are already defined in stdlib.h. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

Use defines for exit code values

2017-06-14T08:53:15+00:00

Make the usage of exit consist. That is use the pre defined exit values. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer