mtd-utils.git/misc-utils/flashcp.c, branch v2.3.1

misc-utils: flashcp: Fix uninitialized variable ‘wrlast_buf’ compiling warning

2025-01-30T17:30:16+00:00

The compiler compains following message: misc-utils/flashcp.c:439:3: warning: ‘wrlast_buf’ may be used uninitialized in this function It won't bring any problems because variable '‘wrlast_buf’ is always initialized before being used. Fix the warning by setting 'wrlast_buf' as NULL when declaring it. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

flashcp: Add write last option.

2023-09-08T11:48:52+00:00

This option is useful for power fail resilient bootloader updates, for systems that check only the partition header for validity before attempting to load the bootloader. For example zynq. Postponing the write of a specified amount of bytes at the beginning of a bootloader makes sure a written bootloader slot is not considered valid until all the data is written. Signed-off-by: David Oberhollenzer

mtd-utils: Add new syntax to get devices by name

2023-05-30T09:12:12+00:00

This introduces a new feature to the MTD command line utilities that allows MTD devices to be referenced by name instead of device node. For example this looks like: > # Display info for the MTD device with name "data" > mtdinfo mtd:data > # Copy file to MTD device with name "data" > flashcp /my/file mtd:data This follows the syntax supported by the kernel which allows MTD device's to be mounted by name[1]. Add the function mtd_find_dev_node() that accepts an MTD "identifier" and returns the MTD's device node. The function accepts a string starting with "mtd:" which it treats as the MTD's name. It then attempts to search for the MTD, and if found maps it back to the /dev/mtdX device node. If the string does not start with "mtd:", then assume it's the old style and refers directly to a MTD device node. The function is then hooked into existing tools like flashcp, mtdinfo, flash_unlock, etc. To load in the new MTD parsing code in a consistent way across programs. [1] http://www.linux-mtd.infradead.org/faq/jffs2.html#L_mtdblock Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: correct casting for percent display

2023-04-24T07:01:37+00:00

Add correct casting for written to prevent overflow that size_t is only 32 bits on a 32-bit platform. Signed-off-by: cchoux Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

misc-utils: flashcp: abort on --partition and --erase-all

2022-11-07T07:24:45+00:00

Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: verify data in --partition

2022-11-07T07:24:44+00:00

The --partition mode is not verifying that data is being written successfully. Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: fix buffer overflow

2022-11-07T07:24:42+00:00

The DIFF_BLOCKS code requires that src and dest buffers be large enough to hold one MTD erasesize. This is because each loop operates on one eraseblock so that it can erase and write one whole sector. But the src and dest buffers are fixed at BUFSIZE, so on platforms where the MTD erasesize are larger then BUFSIZE it will overflow the buffers. Instead allocate the buffers dynamically so that they can be sized to fit the erasesize. Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: simplify logging

2022-11-07T07:24:36+00:00

Most of the uses of log_printf fall into two styles > if (flags & FLAG_VERBOSE) > log_printf(LOG_NORMAL, ...); or > log_printf(LOG_ERROR, ...) > exit(EXIT_FAILURE); Replace them with log_verbose and log_failure respectively. Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: add safe_memerase

2022-11-07T07:24:35+00:00

Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

misc-utils: flashcp: check for lseek errors

2022-11-07T07:24:33+00:00

Add a safe_lseek wrapper to check for lseek errors. Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer