mtd-utils.git/lib, branch v2.1.3

mtd-utils: flash_erase: Add flash erase chip

2021-05-05T06:29:50+00:00

Some flash types support full erase chip command which can reduce the flash erase time. Try first to erase the entire flash and fall back to the old method if the operation fails. Signed-off-by: Larisa Ileana Grigore Signed-off-by: David Oberhollenzer

Remove headers from EXTRA_DIST

2021-01-20T10:53:51+00:00

This commit removes the C header files from the EXTRA_DIST variables and instead assigns them to the SOURCE variable of the respective components they belong to. This takes care of having them distributed in the release tar ball and helps with dependency tracking a little. Signed-off-by: David Oberhollenzer

libmtd: avoid divide by zero

2020-11-29T22:39:41+00:00

The concept of erase blocks doesn't apply to mtd-ram devices. Such devices set MTD_NO_ERASE to indicate this and some report 0 for the erase block size. Avoid a divide by zero when calculating the erase block count for such devices. Signed-off-by: Chris Packham Acked-by: Richard Weinberger Signed-off-by: David Oberhollenzer

mtd-utils: Fix potentially unterminated strings

2020-02-09T21:13:18+00:00

This commit fixes some uses of strncpy that could leave the destination buffer unterminated. Signed-off-by: David Oberhollenzer

mtd-utils: Fix "are we really at EOF" test logic in libubi read_data

2020-02-09T21:13:18+00:00

The function reads file data into a buffer and then checks if we actually are at the end-of-file by trying to read one more byte. For whatever reason, the code uses an int instead of a char. It's not pretty but works. But again, this is something that every static analysis tool barks at. Further more, the error messages are inverted. "We aren't at EOF yet" is printed on failure and something like "read error %m" is printed on success. This patch fixes all of the above. Signed-off-by: David Oberhollenzer

mtd-utils: Fix some simple cases of uninitialized value reads

2020-02-09T21:13:18+00:00

This patch modifies the internal helpers to read and parse integers from sysfs files by initializing them first and removes turns an obscure "a = open(...) if (a >= 0) {...} if (a == -1) {...}" inside recv_image into a more straight forward if/else branch. Signed-off-by: David Oberhollenzer

mtd-utils: Fix various TOCTOU issues

2020-02-09T21:13:18+00:00

This patch restructures various code parts that follow the pattern of "stat(x, &sb) ... makes_sense(&sb) ... open(x)". Signed-off-by: David Oberhollenzer

libmtd: don't leak temporary buffers

2019-11-10T14:30:04+00:00

Signed-off-by: David Oberhollenzer

mtd-utils: Instead of doing preprocessor magic, just output off_t as long long

2018-10-02T12:00:28+00:00

Fix warnings abot PRIdoff_t in libmtd.c, in mtd_read (and mtd_write): In file included from ../git/lib/libmtd.c:40:0: ../git/lib/libmtd.c: In function 'mtd_read': ../git/include/common.h:110:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t {aka long long int}' [-Wformat=] ../git/include/common.h:120:2: note: in expansion of macro 'errmsg' errmsg(fmt, ##__VA_ARGS__); \ ^~~~~~ ../git/lib/libmtd.c:1082:10: note: in expansion of macro 'sys_errmsg' return sys_errmsg("cannot seek mtd%d to offset %"PRIdoff_t, ^~~~~~~~~~ /usr/lib/klibc/include/inttypes.h:28:17: note: format string is defined here #define PRId32 "d" Signed-off-by: Thorsten Glaser Signed-off-by: David Oberhollenzer

libmtd: don't print an error message for devices without ecc support

2018-09-20T09:27:01+00:00

The libmtd library tries to obtain the available OOB size via the sysfs with a fallback to the ECCGETLAYOUT ioctl. For some devices (e.g. plat-ram), the fallback path is always taken and prints an error message to stderr since the ioctl fails. This patch fixes the fallback path by suppressing the error message if errno is set to EOPNOTSUPP (i.e. the device simply doesn't support that). Fixes: a10353584f93 ("libmtd: Add support to access OOB available size") Reported-by: Chris Packham Reviewed-by: Xiaolei Li Tested-by: Chris Packham Signed-off-by: David Oberhollenzer