mtd-utils.git/lib, branch v1.4.5

punt redundant libcrc32

2011-06-25T06:10:49+00:00

The libcrc32.a is only used in one place: mkfs.ubifs. But this also uses libmtd.a, and the only file in libcrc32.a is also in libmtd.a. So libcrc32.a itself is completely redundant. Punt! Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

libmtd: improve mtd_islocked interface

2011-06-08T12:30:14+00:00

This patch first of all, re-names 'mtd_islocked()' into 'mtd_is_locked()' since this seems to be the name Mike wanted, and it looks a bit nicer. This patch also makes 'mtd_is_locked()' print an error message if it fails. I'm not sure if it is good idea for a library to do so, but all functions do this, so it certainly _not_ a good idea to be inconsistent. However, for the special case, when the the "is locked" ioctl is not supported or is not valid for this device, we do not print an error message and return ENOTSUPP error code. Thus, the user can distinguish between real errors and non-fatal "not supported" cases. Signed-off-by: Artem Bityutskiy

libmtd: add helper funcs for getting regioninfo and locked info

2011-06-08T11:58:14+00:00

This extends the libmtd with the helper functions: mtd_regioninfo: interface to MEMGETREGIONINFO mtd_islocked: interface to MEMISLOCKED Users of these functions will follow shortly ... Artem: do not print error message in mtd_islocked() Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

libmtd: use O_CLOEXEC

2011-06-07T06:52:51+00:00

Not strictly necessary, but this is good library behavior and should carry no runtime overhead. Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

libmtd: use PRIu64 classifier for uint64_t printf arguments

2011-04-21T12:43:39+00:00

Signed-off-by: Andy Shevchenko Acked-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

libmtd: fix OOB read and write interface

2011-04-01T16:31:43+00:00

When reading and writing OOB we specify the address as absolute offset from the beginning of the MTD device. This offset is basically an absolute page offset plus the OOB offset. And it does not have to be aligned to the min. I/O unit size (NAND page size). So fix the 'do_oob_op()' function and remove incorrect checking that the offset is page-aligned. This check leads to the following errors: libmtd: error!: unaligned address 2, mtd0 page size is 2048 But obviously, the intent was to write to offset 2 of the OOB area of the very first NAND page. Instead of that incorrect check, we should check that the OOB offset we write to is within the OOB size and the length is withing the OOB size. This patch adds such check. Reported-by: Kelly Anderson Signed-off-by: Artem Bityutskiy Tested-by: Kelly Anderson

libmtd: fix OOB size initialization in legacy code

2010-11-29T14:57:35+00:00

legacy_get_dev_info() forgot to set the OOB size Signed-off-by: Ketil Froyn Signed-off-by: Artem Bityutskiy

libmtd: make malloc failures fatal

2010-10-02T14:19:44+00:00

This converts libmtd to the common xalloc helpers and in doing so, makes memory allocation failures fatal rather than returning an error to the caller. I think this is acceptable behavior. Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

sumtool/libfec: convert "()" to "(void)" in func defs

2010-10-02T14:16:36+00:00

Since these functions take no parameters, declare them as such. The subtle difference here is that gcc allows (without warning) people to accidentally call funcs declared with "()" with arguments. Using void makes sure that gcc will reject such typos at compile time. Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy

libmtd: unify some error messages

2010-10-01T06:34:16+00:00

By using the same error message string, we only need one copy of it in memory at runtime. Signed-off-by: Mike Frysinger Signed-off-by: Artem Bityutskiy