mtd-utils.git/lib/libmtd_legacy.c, branch v2.3.1

libmtd: Add function to get MTD info by device name

2023-05-30T09:12:12+00:00

This is a convenience function for end users. In some situations it's easier to reference MTD device's by their name then by MTD number, as the name may be more reliable if device partitioning is dynamic or for porting between systems. Signed-off-by: Brandon Maier Signed-off-by: David Oberhollenzer

mtd-utils: Fix various TOCTOU issues

2020-02-09T21:13:18+00:00

This patch restructures various code parts that follow the pattern of "stat(x, &sb) ... makes_sense(&sb) ... open(x)". Signed-off-by: David Oberhollenzer

libmtd: don't print an error message for devices without ecc support

2018-09-20T09:27:01+00:00

The libmtd library tries to obtain the available OOB size via the sysfs with a fallback to the ECCGETLAYOUT ioctl. For some devices (e.g. plat-ram), the fallback path is always taken and prints an error message to stderr since the ioctl fails. This patch fixes the fallback path by suppressing the error message if errno is set to EOPNOTSUPP (i.e. the device simply doesn't support that). Fixes: a10353584f93 ("libmtd: Add support to access OOB available size") Reported-by: Chris Packham Reviewed-by: Xiaolei Li Tested-by: Chris Packham Signed-off-by: David Oberhollenzer

libmtd_legacy: Fix some function description mismatches

2018-04-10T13:38:59+00:00

Signed-off-by: Xiaolei Li Signed-off-by: David Oberhollenzer

libmtd: Add support to access OOB available size

2018-04-10T13:38:56+00:00

This patch exposes OOB available size to user. Then user can use OOB free area according to OOB available size. Steps to get OOB available size: First, access /sys/class/mtd/mtdX/oobavail. If not exist, then try to get ecc layout by ioctl "ECCGETLAYOUT". If none of them work, set OOB available size to 0. Signed-off-by: Xiaolei Li Signed-off-by: David Oberhollenzer

Fix libmtd behaviour if MTD is not present on the system

2017-03-15T11:10:34+00:00

The documentation of libmtd_open says, if it returns NULL and errno is zero, MTD is not present. However, the current version always returns a libmtd_t object. The function internally checks, if it can access the MTD sysfs files and, if not, sets a flag to use the procfs fallback. This patch adds an additional check to libmtd_open, to test if the MTD procfs file can be read and fails with errno cleared if it does not exist. Furhtermore, mtd_get_info is documented to fail with errno set to ENODEV if MTD is not present. First of all, this was broken in the original version. It was implemented to specification for the sysfs code path, but if MTD is not present, that won't be executed, because of the flag set by libmtd_open. This makes the check not only redundant, but masks an actual error (the sysfs paths suddenly not being readable anymore). The legacy path that was used if the sysfs files are not avaible fails with ENOENT if it cannot read the procfs file. With the above changes in addition, we don't have a libmtd_t object if neither sysfs nor procfs is readable, so this error status no longer makes sense. This patch removes the documentation on the ENODEV errno, and makes sure that mtd_get_info always returns with apropriate errno on failure. Signed-off-by: David Oberhollenzer

Remove unused legacy_libmtd_open internal libmtd function

2016-11-17T10:36:55+00:00

Signed-off-by: David Oberhollenzer Signed-off-by: Richard Weinberger

add the MTD_MLCNANDFLASH case

2013-10-22T23:17:52+00:00

The MTD_MLCNANDFLASH case is missed in the current code. This patch adds it. Signed-off-by: Huang Shijie Signed-off-by: Brian Norris

libmtd_legacy: don't open device in R/W

2012-02-29T07:19:17+00:00

On legacy kernels with ROM devices, we can get mtdinfo errors like: libmtd: error!: cannot open "/dev/mtd4" error 13 (Permission denied) mtdinfo: error!: libmtd failed get MTD device 4 information error 13 (Permission denied) We don't need O_RDRW access for informational ioctls(), so make this O_RDONLY. Signed-off-by: Brian Norris Signed-off-by: Artem Bityutskiy

limbtd: implement mtd_dev_present for old kernels

2012-02-14T09:00:09+00:00

Implement the 'legacy_dev_present()' function which will check whether an MTD device is present by scanning the /proc/mtd file when the MTD subsystem does not support sysfs (the case for pre-2.6.30 kernels). This patch also moves the 'mtd_dev_present()' function to a slightly more logical position. Signed-off-by: Artem Bityutskiy