mtd-utils.git/jffsX-utils, branch v2.3.0

jffsX-utils: jffs2reader: Fix potential null pointer dereference compiling warning for 'path'

2025-01-30T17:30:16+00:00

The compiler compains following message: jffsX-utils/jffs2reader.c:697:6: warning: potential null pointer dereference It won't bring any problems because the 'path' is guaranteed to be a non-NULL variable. Fix the warning by adding a NULL pointer check. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

jffsX-utils: fix integer overflow in jffs2dump.c

2024-12-24T16:22:12+00:00

Report of the static analyzer: The value of an arithmetic expression 'datsize + oobsize' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic. Corrections explained: - Added a check to validate datsize and oobsize to ensure they are non-negative and within a safe range. - Cast datsize and oobsize to long before performing arithmetic to prevent potential integer overflow. This change ensures safe computation of offsets and prevents undefined behavior caused by overflow. Signed-off-by: Anton Moryakov Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

mkfs.jffs2: fix segfault when parsing dev table

2024-10-08T07:01:11+00:00

Make sure that the first item is parsed correctly. One issue otherwise is a null pointer dereference when the first item is not found. Signed-off-by: Rosen Penev Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

mtd-utils: Extract rbtree implementation to common lib

2024-09-25T13:03:08+00:00

Current rbtree implementation code is put under jffs utils, extract it into common lib, and add more rbtree operations(eg. rb_first_postorder, rb_next_postorder, etc.). This is a preparation for replacing implementation of UBIFS utils with linux kernel libs. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

mtd-utils: Extract list implementation to common lib and add list_sort support

2024-09-25T13:03:08+00:00

Current list implementation code is put under jffs utils, extract it into common lib, and add more list operations(eg. list_move, list_splice, etc.). Besides, add list sorting support in new source file lib/list_sort.c. This is a preparation for replacing implementation of UBIFS utils with linux kernel libs. Signed-off-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

Make zlib an optional dependency

2024-02-18T13:27:31+00:00

Now that we have plumbing in place for both jffsX-utils and mkfs.ubifs, add the missing autoconf and automake changes to allow mtd-utils to be built without a hard dependency on zlib. Signed-off-by: David Oberhollenzer

Make it possible to compile jffsX-utils without zlib

2024-02-18T12:54:59+00:00

The jffsX-utils already have a CONFIG_JFFS2_ZLIB define, but it is statically defined in a header and not used consistently. This patch first replaces it with a "WITH_ZLIB" define, provided via automake, to bring it in line with the already existing "WITH_LZO". Then, the missing checks and typedefs are added in jffs2reader.c. Signed-off-by: David Oberhollenzer

Fix optional compilation of lzo compressors

2024-02-17T20:20:34+00:00

- Simple fixup in autoconf.ac - Make compilation of jffsX-utils compr_lzo.c optional. Simply don't compile it if we built without LZO and remove the place holders. They are not used anyway if we build without LZO. Signed-off-by: David Oberhollenzer

Cleanup handling of optional dependencies

2024-02-15T14:07:17+00:00

Don't use super pedantic parsing of the argument and work with the generated variable instead of assigning it to our own and set it to "check" if not value is assigned. Then search for a dependency if the with variable is anything other than "no" and fail if it was set to "yes". In addition, the WITHOUT_xxx defines are replaced with WITH_xxx defines. Signed-off-by: David Oberhollenzer

jffs2dump: check return value of lseek

2023-09-02T14:11:44+00:00

On error, lseek returns a negative value. We need to check for that and abort, instead of passing -1 to malloc and later on to read_nocheck. Signed-off-by: David Oberhollenzer