mtd-utils.git/jffsX-utils/mkfs.jffs2.c, branch v2.3.1

mkfs.jffs2: fix segfault when parsing dev table

2024-10-08T07:01:11+00:00

Make sure that the first item is parsed correctly. One issue otherwise is a null pointer dereference when the first item is not found. Signed-off-by: Rosen Penev Reviewed-by: Zhihao Cheng Signed-off-by: David Oberhollenzer

Cleanup handling of optional dependencies

2024-02-15T14:07:17+00:00

Don't use super pedantic parsing of the argument and work with the generated variable instead of assigning it to our own and set it to "check" if not value is assigned. Then search for a dependency if the with variable is anything other than "no" and fail if it was set to "yes". In addition, the WITHOUT_xxx defines are replaced with WITH_xxx defines. Signed-off-by: David Oberhollenzer

mkfs.jffs2: fix spelling of --compression-mode parameter in help text

2022-09-27T06:32:46+00:00

--compr-mode is not accepted as an alias of --compression-mode. Signed-off-by: Alex Henrie Signed-off-by: David Oberhollenzer

mtd-utils: Fix various TOCTOU issues

2020-02-09T21:13:18+00:00

This patch restructures various code parts that follow the pattern of "stat(x, &sb) ... makes_sense(&sb) ... open(x)". Signed-off-by: David Oberhollenzer

mkfs.jffs2: don't leak temporary buffer if readlink fails

2019-11-10T14:30:04+00:00

Signed-off-by: David Oberhollenzer

mtd-utils: Instead of doing preprocessor magic, just output off_t as long long

2018-10-02T12:00:28+00:00

Fix warnings abot PRIdoff_t in libmtd.c, in mtd_read (and mtd_write): In file included from ../git/lib/libmtd.c:40:0: ../git/lib/libmtd.c: In function 'mtd_read': ../git/include/common.h:110:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t {aka long long int}' [-Wformat=] ../git/include/common.h:120:2: note: in expansion of macro 'errmsg' errmsg(fmt, ##__VA_ARGS__); \ ^~~~~~ ../git/lib/libmtd.c:1082:10: note: in expansion of macro 'sys_errmsg' return sys_errmsg("cannot seek mtd%d to offset %"PRIdoff_t, ^~~~~~~~~~ /usr/lib/klibc/include/inttypes.h:28:17: note: format string is defined here #define PRId32 "d" Signed-off-by: Thorsten Glaser Signed-off-by: David Oberhollenzer

Eliminate warnings about missing prototypes

2017-06-28T08:27:31+00:00

This patch eliminates warnings generated by the -Wmissing-prototypes option. With this flag set, we are now forced to have prototypes for all global, exported functions, that have to be made visible to the definitions and we are forced to mark all local functions as static. Signed-off-by: David Oberhollenzer

jffsX-utils: Return error code if command line option is unknown

2017-06-14T08:55:26+00:00

The tools in question will quit with an exit code 0 if the command line option was not recognized. By returning an error code a calling script has the possibility to distinguish between a real success and an invalid invocation. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

Use defines for exit code values

2017-06-14T08:53:15+00:00

Make the usage of exit consist. That is use the pre defined exit values. Signed-off-by: Daniel Wagner Signed-off-by: David Oberhollenzer

Fix build with musl

2017-03-02T10:46:01+00:00

Signed-off-by: Khem Raj Signed-off-by: David Oberhollenzer