mtd-utils.git/flash_unlock.c, branch v2.3.1

mtd-utils: Restructure the mtd-utils source.

2015-11-11T22:38:40+00:00

* There is no code modification in this commit, only moving * the files to proper place. The user tools looks a little messy as we place almost the all tools in the root directory of mtd-utils. To make it more clear, I propose to introduce the following structure for our source code. mtd-utils/ |-- lib |-- include |-- misc-utils |-- jffsX-utils |-- nand-utils |-- nor-utils |-- ubi-utils |-- ubifs-utils `-- tests Signed-off-by: Dongsheng Yang Signed-off-by: Brian Norris

flash_{un,}lock: document block count == -1

2015-11-11T22:05:36+00:00

These utilities have accepted -1 as a block count to mean "all blocks." Let's document that. Signed-off-by: Brian Norris

flash_{un,}lock: don't allow "last byte + 1"

2015-11-11T22:05:36+00:00

A lock/unlock/islocked ioctl() should be prevented from anything past the last byte, inclusive. But we were doing an exclusive check. This isn't a big deal, as the kernel MTD APIs would be guarding this anyway, but let's do this for completeness. Signed-off-by: Brian Norris

flash_{un,}lock: improve strtol() error handling

2015-11-11T22:05:36+00:00

Use the simple_* helpers to improve error checking. Also fixup brace style at the same time. Signed-off-by: Brian Norris

flash_{un,}lock: add MEMISLOCKED support

2015-11-11T22:05:36+00:00

With the -i / --islocked flags. Sample output: # flash_lock --islocked /dev/mtd0 Device: /dev/mtd0 Start: 0 Len: 0x400000 Lock status: unlocked Return code: 0 Signed-off-by: Brian Norris

flash_{un,}lock: support both lock/unlock in the same binary

2015-11-11T22:05:36+00:00

Add new --lock/--unlock flags, so we can do either with the same binary. This will prepare for the addition of other features, so we don't have to keep duplicating the same binary via #include "flash_unlock.c". The defaults still work as expected: flash_unlock will default to REQUEST_UNLOCK, and flash_lock will default to REQUEST_LOCK. Eventually, we might deprecate one of the two (flash_unlock, probably), so we only have to ship one flash_{un,}lock binary. Signed-off-by: Brian Norris

flash_{un,}lock: move args processing to its own function

2015-11-11T22:05:36+00:00

Signed-off-by: Brian Norris

flash_{un,}lock: abstract the argument positions

2015-11-11T22:05:36+00:00

Previously, there were no options (besides stand-alone --help and --version), so we just used fixed-position argv indexes. Let's change that. Also clean up the sanity checks a bit to make them more verbose and specific. Signed-off-by: Brian Norris

flash_{un,}lock: document option flags

2015-11-11T22:05:36+00:00

Signed-off-by: Brian Norris

flash_{un,}lock: support --version flag

2015-11-11T22:05:36+00:00

Just use the common helper macro. Signed-off-by: Brian Norris