mtd-utils.git, branch v2.1.2

Release mtd-utils-2.1.2

2020-07-13T08:06:37+00:00

Signed-off-by: David Oberhollenzer

Add the mkfs.ubifs sign.h header to the list of sources

2020-07-13T08:03:42+00:00

The sign.h header added by the authentication patch set was omitted from the automake file and thus not added to the distribution tarball. The resulting tarballs were unable to be compiled. Fixes: a739b59 ("mkfs.ubifs: Add authentication support") Signed-off-by: David Oberhollenzer

mkfs.ubifs: fix broken build if fscrtyp is disabled

2020-02-09T22:04:41+00:00

First, there is no option named of X509_OPTION. It was presumably changed during development to AUTH_CERT_OPTION. This commit fixes the name in the !WITH_CRYPTO branch. Similarly, '}' got moved into the WITH_CRYPTO branch, but not into else branch, resulting in tons of errors if fscrypt is disabled. This commit pulls it back out of both branches. Fixes: a739b59e ("mkfs.ubifs: Add authentication support") Signed-off-by: David Oberhollenzer

mtd-utils: Add checks to code that copies strings into fixed sized buffers

2020-02-09T21:13:18+00:00

Signed-off-by: David Oberhollenzer

mtd-utils: Fix potentially unterminated strings

2020-02-09T21:13:18+00:00

This commit fixes some uses of strncpy that could leave the destination buffer unterminated. Signed-off-by: David Oberhollenzer

mtd-utils: Fix "are we really at EOF" test logic in libubi read_data

2020-02-09T21:13:18+00:00

The function reads file data into a buffer and then checks if we actually are at the end-of-file by trying to read one more byte. For whatever reason, the code uses an int instead of a char. It's not pretty but works. But again, this is something that every static analysis tool barks at. Further more, the error messages are inverted. "We aren't at EOF yet" is printed on failure and something like "read error %m" is printed on success. This patch fixes all of the above. Signed-off-by: David Oberhollenzer

mtd-utils: Fix wrong argument to sizeof in nanddump

2020-02-09T21:13:18+00:00

Some temporary buffers are allocated with "sizeof(pointer) * count" as size argument, which cannot possibly be correct. Assuming what was meant was "sizeof(pointer[0]) * count" makes sense in the context of how the buffers are used, but is actually pretty pointless, since the buffers are unsigend char. Signed-off-by: David Oberhollenzer

mtd-utils: Fix some simple cases of uninitialized value reads

2020-02-09T21:13:18+00:00

This patch modifies the internal helpers to read and parse integers from sysfs files by initializing them first and removes turns an obscure "a = open(...) if (a >= 0) {...} if (a == -1) {...}" inside recv_image into a more straight forward if/else branch. Signed-off-by: David Oberhollenzer

mtd-utils: Fix various TOCTOU issues

2020-02-09T21:13:18+00:00

This patch restructures various code parts that follow the pattern of "stat(x, &sb) ... makes_sense(&sb) ... open(x)". Signed-off-by: David Oberhollenzer

mtd-utils: Fix potential negative arguments passed to close(2)

2020-02-09T21:13:18+00:00

Many tools open a file descriptor, close it a the end and have some form of error path in between that jumps to the end. In some cases, if opening the file fails the error path is taken and the utility ends up closing one or more invalid file descriptors. It's technically not a real issue but something that pretty much any static analysis tool barks at. Signed-off-by: David Oberhollenzer